Replace card_horizontal component with card attr. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of separate card and card_horizontal components, add the :direction attribute to the card component.
houhoulis
commented
Jan 10, 2025
|
|
||
| defp content_card_horizontal(assigns) do | ||
| defp content_card(assigns) do |
There was a problem hiding this comment.
I could have pattern-matched the content_card function the way I did the card function. But there is only one word's difference between the two content_card function bodies, so I used one if statement to consolidate.
TheFirstAvenger
approved these changes
Jan 17, 2025
Co-authored-by: Mike Binns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of separate card and card_horizontal components, add the :direction attribute to the card component.
Resolves #17 .