Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SC buy errors #108

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Fixed SC buy errors #108

merged 11 commits into from
Apr 24, 2024

Conversation

Ronnieraj37
Copy link
Contributor

Fixed Unwanted transactions while buying StableCoin

Issue:

I identified these 2 issues:

  • Buying also works when token input is set to 0
  • If wallet is not connect and Install metamask is clicked it initiates a transaction will NULL input
Untitled.video.-.Made.with.Clipchamp.2.mp4

Fix:

  • Fixed this by adding better checks using parseInt as the input type is not number
  • Added a simple isWalletConnected check as the Install Metamask Button triggers the onSubmit in the form
Untitled.video.-.Made.with.Clipchamp.1.mp4

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
djed-solidity-web-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 8:55am

@Ronnieraj37 Ronnieraj37 changed the title Fix buy errors Fixed buy errors Apr 14, 2024
@Ronnieraj37 Ronnieraj37 changed the title Fixed buy errors Fixed SC buy errors Apr 14, 2024
Copy link
Contributor

@ceilican ceilican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ronnieraj37 ! Thanks for this fix. I noticed that the same problem exists in src/routes/reservecoin.jsx .

Could you fix it there too, before we merge this PR?

@Ronnieraj37
Copy link
Contributor Author

Hey @ceilican , I've Fixed the errors in Reservcoin.jsx as well. Please check if it works now.

@Ronnieraj37 Ronnieraj37 requested a review from ceilican April 23, 2024 08:56
@ceilican ceilican merged commit 799bfbf into DjedAlliance:main Apr 24, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants