Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js css files #193

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Js css files #193

wants to merge 6 commits into from

Conversation

LoFenk
Copy link

@LoFenk LoFenk commented Nov 15, 2023

Moved inline styles and scripts to files so as not to trigger CSP errors, and fixed two other issues that were triggering CSP errors.

List of changes:

  • Moved all inline css and javascript to css files / js files
  • Moved block.super to base, as it needs to load jquery before the scripts are loaded
  • Small change in the javascript as it triggered an 'eval()' CSP error
  • Added actions_on_top = True to the report view to remove the inline script injected by django (it doesn't seem to do anything wether it's True or False)
  • Added package_data to setup.py

That's about it I think - it now works within stricter CSP settings and now the columns appear flush so there's no need to fiddle with the tables as I previously stated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant