feat: added basic auth support and moved the code base to typescript #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code does not work when you directly download it from github.com as it done currently in storefront-api and vsf-api, so when it gets merged we need to change it so it gets published and maybe to give some people time to move to the npm version we first merge it into an typescript branch maybe? |
|
Any news here when someone will have a look into it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for basic auth. Basic auth can be done in two ways with this you can add it to the url with https://:@example.org or you can add it with the config with basicAuth.password and basicAuth.user both ways need to have basicAuth.enabled set to true to work.
The other thing is now the whole code base is written in typescript and should be build in a way that works for publishing to npm. The down side of this could only be that people that use it in a repo that does not habe typescript enabled so vsf-api should be fine who get it directly from this repo could have problems.