fix: lookup of smart router quotes (#920)

* fix: lookup of smart router quotes * fix: failing tests * fix: add types
DistributedCollective · May 22, 2024 · a53308e · a53308e
1 parent 865976c
commit a53308e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/.changeset/nasty-avocados-float.md b/.changeset/nasty-avocados-float.md
@@ -0,0 +1,5 @@
+---
+'@sovryn/sdk': patch
+---
+
+fix: smart router lookup
diff --git a/packages/sdk/src/swaps/smart-router/smart-router.ts b/packages/sdk/src/swaps/smart-router/smart-router.ts
@@ -58,14 +58,24 @@ export class SmartRouter {
       destination,
     );
 
-    const quotes = await Promise.all(
-      routes.map(async route => {
-        const quote = await route.quote(entry, destination, amount).catch();
-        if (!quote) {
-          return { route, quote: BigNumber.from(0) };
-        }
-        return { route, quote };
-      }),
+    const quotes = await Promise.allSettled(
+      routes.map(route =>
+        route
+          .quote(entry, destination, amount)
+          .then(quote => ({ route, quote })),
+      ),
+    ).then(results =>
+      results
+        .filter(result => result.status === 'fulfilled')
+        .map(
+          result =>
+            (
+              result as PromiseFulfilledResult<{
+                route: SwapRoute;
+                quote: BigNumber;
+              }>
+            ).value,
+        ),
     );
 
     const sortedQuotes = quotes.sort((a, b) =>