SOV-4157: Fix maximum value in AmountInput (#912)

* Fix maximum value in AmountInput * Create nervous-mails-punch.md
DistributedCollective · May 15, 2024 · 05ffbb5 · 05ffbb5
1 parent 6797b95
commit 05ffbb5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/.changeset/nervous-mails-punch.md b/.changeset/nervous-mails-punch.md
@@ -0,0 +1,5 @@
+---
+"@sovryn/ui": patch
+---
+
+SOV-4157: Fix maximum value in AmountInput
diff --git a/packages/ui/src/2_molecules/AmountInput/AmountInput.test.tsx b/packages/ui/src/2_molecules/AmountInput/AmountInput.test.tsx
@@ -1,4 +1,4 @@
-import { render, waitFor } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 
 import React from 'react';
@@ -107,19 +107,6 @@ describe('AmountInput', () => {
     expect(amountInput).toHaveProperty('lang', 'sk-SK');
   });
 
-  test('does not allow to enter more than 9 whole numbers', async () => {
-    const { getByTestId } = render(
-      <AmountInput value={2} dataAttribute="test" />,
-    );
-
-    const amountInput = getByTestId('test');
-
-    userEvent.clear(amountInput);
-    userEvent.paste(amountInput, '10000000000000');
-
-    await waitFor(() => expect(amountInput).toHaveValue('999999999'));
-  });
-
   test('trims unnecessary zeros at the end on blur', async () => {
     const { getByTestId } = render(
       <AmountInput

diff --git a/packages/ui/src/2_molecules/AmountInput/AmountInput.tsx b/packages/ui/src/2_molecules/AmountInput/AmountInput.tsx
@@ -15,7 +15,7 @@ import { HelperButton } from '../HelperButton/HelperButton';
 import styles from './AmountInput.module.css';
 
 const MAX_DECIMALS = 18;
-const MAX_VALUE = 999999999;
+const MAX_VALUE = Number.MAX_VALUE;
 
 export enum AmountInputVariant {
   large = 'large',
@@ -78,7 +78,7 @@ export const AmountInput = React.forwardRef<HTMLInputElement, AmountInputProps>(
           unformattedNumberValue = String(maxAmount);
         }
 
-        if (Number(unformattedNumberValue) >= MAX_VALUE + 1) {
+        if (Number(unformattedNumberValue) >= MAX_VALUE) {
           unformattedNumberValue = String(MAX_VALUE);
         }