Rootstock stg #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Close notification center when a notification is opened * chore: Add comment
* Fix: prompt -> confirm * Update unit test
* Fix tests * Remove unused import
Also includes refactoring: always pass wei to SendAmountBlock
* Tests: mock fetch in PermissionsCheck tests * Fix mocks
* Fix tests
* feat: make do not copy the primary CTA in the address copy warning modal * fix: lint errors * fix: mobiles styles * remove outline from copy button
* use latest subgraphs * fix multisend handling * query multisend addresses configured on roles mod * use queried known multisend address * handle multisend impossible edge case * fold execute through role section into the main sign or execute card * fix exec through role status checks * design updates * add powered by zodiac badge * test hooks * improve tests * test coverage for new logic in SignOrExecute main component * fix a bug and margins between error messages * fix a bug: offer exec through role also if threshold is 1 but not connected with owner * adjust test and improve error messages * don't offer exec through role for safe owners if role lacks permissions * fix failing test * use client gateway to fetch tx id closes #3815 * mock useGasPrice --------- Co-authored-by: Jan-Felix <[email protected]>
* Tests: fix regression tests
* fix(UI): chain prefix toggle in address display * chore: fix linting issues * fix(UI): logic for chain prefix toggle
…ers is missing in a tx (#4260) * fix(display-raw-data): show raw data if no params and method exists in a tx * chore(readability): improve condition readability * chore(unit-tests): add raw data test case in DecodedTx component
* Prevent failing step * Hide beamer before all tests * Update workflow
Decoding in the SignOrExecuteForm was displayed twice for stake and swap txs.
* Tests refactoring/cleanup
* fix: useLoadChains should follow the next url
The getConfigs function was using the client gateway sdk to fetch the
chains. This call is limited to 20 items and we never try to fetch more.
The config service now has more than 20 networks and we are missing them
in the url. It turned out however that it is very difficult to provide
the {offset, limit} arguments to the getChainInfo on the sdk. Something
seems wrong and generated next url is wrong.
That’s why I opted out of using the sdk for this call and instead
directly fetch the results and follow the next prop on the returned
object until there is nothing more.
* fix: Change color of New chip in sidebar
DenSmolonski
force-pushed
the
rootstock-stg
branch
from
0a91e39
to
6099b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist