fix: optional variadic arguments no longer can be stuck in infinite l…

…oops (#825)
DisnakeDev · Oct 25, 2022 · 4f604ff · 4f604ff
1 parent a69c1de
commit 4f604ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changelog/825.bugfix.rst b/changelog/825.bugfix.rst
@@ -0,0 +1 @@
+|commands| Fix a case where optional variadic arguments could have infinite loops in parsing depending on the user input.
diff --git a/disnake/ext/commands/core.py b/disnake/ext/commands/core.py
@@ -576,7 +576,10 @@ async def transform(self, ctx: Context, param: inspect.Parameter) -> Any:
             try:
                 argument = view.get_quoted_word()
             except ArgumentParsingError as exc:
-                if self._is_typing_optional(param.annotation):
+                if (
+                    self._is_typing_optional(param.annotation)
+                    and not param.kind == param.VAR_POSITIONAL
+                ):
                     view.index = previous
                     return None
                 else:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		\|commands\| Fix a case where optional variadic arguments could have infinite loops in parsing depending on the user input.