feature: avoid making a PATCH request when command didn't need to be …

…updated

Examples/Commands.luau

@@ -4,20 +4,31 @@ local Env = require("../.env")
 local DiscordSettings = DiscordLuau.DiscordSettings.new(Env.DISCORD_BOT_TOKEN)
 local DiscordClient = DiscordLuau.DiscordClient.new(DiscordSettings)
 
+DiscordClient:setVerbose(true)
+
 DiscordClient:on("Ready", function()
 	print(`🎉🎉 {DiscordClient.discordUser.username} is online! 🎉🎉`)
 
 	local permissions = DiscordLuau.DiscordPermissions.new()
 
 	permissions:addPermission(DiscordLuau.DiscordPermissions.Permissions.UseApplicationCommands)
 
-	local slashCommand = DiscordLuau.ApplicationCommand.new()
-		:setName("example-command")
-		:setDescription("Example Description")
+	local slashCommand0 = DiscordLuau.ApplicationCommand.new()
+		:setName("example-0")
+		:setDescription("...")
+		:setGuildPermissions(permissions)
+		:addContext(DiscordLuau.ApplicationCommand.Context.Guild)
+		:setType(DiscordLuau.ApplicationCommand.Type.ChatInput)
+
+	local slashCommand1 = DiscordLuau.ApplicationCommand.new()
+		:setName("example-1")
+		:setDescription("abc!")
 		:setGuildPermissions(permissions)
+		:addContext(DiscordLuau.ApplicationCommand.Context.Guild)
+		:setType(DiscordLuau.ApplicationCommand.Type.ChatInput)
 
 	DiscordClient.discordApplication:setSlashCommandsAsync({
-		slashCommand
+		slashCommand0, slashCommand1
 	}):after(function(data)
 		print("updated, fetching current commands..")
 		DiscordClient.discordApplication:fetchSlashCommandsAsync():after(function(...)

Examples/Development.luau

@@ -9,16 +9,32 @@ DiscordClient:setVerbose(true)
 DiscordClient:on("Ready", function()
 	print(`🎉🎉 {DiscordClient.discordUser.username} is online! 🎉🎉`)
 
-	local channelObject = DiscordClient:fetchChannelAsync("1048686561685946489"):await()
-
-	channelObject:sendMessageAsync({
-		embeds = {
-			DiscordLuau.DiscordEmbed.new()
-				:setTitle("Hello, World!")
-				:setColor(0xFF0000)
-				:setDescription("A test embed object!")
-		}
-	})
+	local permissions = DiscordLuau.DiscordPermissions.new()
+
+	permissions:addPermission(DiscordLuau.DiscordPermissions.Permissions.UseApplicationCommands)
+
+	local slashCommand0 = DiscordLuau.ApplicationCommand.new()
+		:setName("example-0")
+		:setDescription("...")
+		:setGuildPermissions(permissions)
+		:addContext(DiscordLuau.ApplicationCommand.Context.Guild)
+		:setType(DiscordLuau.ApplicationCommand.Type.ChatInput)
+
+	local slashCommand1 = DiscordLuau.ApplicationCommand.new()
+		:setName("example-1")
+		:setDescription("abc!")
+		:setGuildPermissions(permissions)
+		:addContext(DiscordLuau.ApplicationCommand.Context.Guild)
+		:setType(DiscordLuau.ApplicationCommand.Type.ChatInput)
+
+	DiscordClient.discordApplication:setSlashCommandsAsync({
+		slashCommand0, slashCommand1
+	}):after(function(data)
+		print("updated, fetching current commands..")
+		-- DiscordClient.discordApplication:fetchSlashCommandsAsync():after(function(...)
+		-- 	print(...)
+		-- end)
+	end)
 end)
 
 DiscordClient:connectAsync()

Package/Classes/ApplicationCommand.luau

@@ -51,7 +51,7 @@ ApplicationCommand.Interface.Context = Enumerate.new({
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setType(self: ApplicationCommand, commandType: number): ApplicationCommand
+function ApplicationCommand.Prototype.setType(self: ApplicationCommand, commandType: number)
 	assert(ApplicationCommand.Interface.Type:Is(commandType), `Expected 'commandType' to of enum 'commandType'`)
 
 	self.commandType = commandType
@@ -73,7 +73,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setLocalization(self: ApplicationCommand, localizationCode: string): ApplicationCommand
+function ApplicationCommand.Prototype.setLocalization(self: ApplicationCommand, localizationCode: string)
 	self.commandLocalization = localizationCode
 
 	return self
@@ -93,7 +93,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setDescription(self: ApplicationCommand, description: string): ApplicationCommand
+function ApplicationCommand.Prototype.setDescription(self: ApplicationCommand, description: string)
 	self.commandDescription = description
 
 	return self
@@ -113,7 +113,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setName(self: ApplicationCommand, name: string): ApplicationCommand
+function ApplicationCommand.Prototype.setName(self: ApplicationCommand, name: string)
 	self.commandName = name
 
 	return self
@@ -133,7 +133,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setNSFW(self: ApplicationCommand, isNSFW: boolean): ApplicationCommand
+function ApplicationCommand.Prototype.setNSFW(self: ApplicationCommand, isNSFW: boolean)
 	self.commandNSFW = isNSFW
 
 	return self
@@ -153,7 +153,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setDMPermission(self: ApplicationCommand, canDM: boolean): ApplicationCommand
+function ApplicationCommand.Prototype.setDMPermission(self: ApplicationCommand, canDM: boolean)
 	self.commandDM = canDM
 
 	return self
@@ -173,7 +173,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.setGuildPermissions(self: ApplicationCommand, permissionObject: DiscordPermissions.DiscordPermissions): ApplicationCommand
+function ApplicationCommand.Prototype.setGuildPermissions(self: ApplicationCommand, permissionObject: DiscordPermissions.DiscordPermissions)
 	self.commandPermissions = permissionObject
 
 	return self
@@ -193,12 +193,32 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.addOption(self: ApplicationCommand, commandObject: ApplicationCommandOption.ApplicationCommandOptions): ApplicationCommand
+function ApplicationCommand.Prototype.addOption(self: ApplicationCommand, commandObject: ApplicationCommandOption.ApplicationCommandOptions)
 	table.insert(self.options, commandObject)
 
 	return self
 end
 
+--[=[
+	@method addOption
+	@within ApplicationCommand
+
+	@param commandObject !ApplicationCommandOption
+
+	@return ApplicationCommand
+
+	(yet-to-do!)
+
+	```lua
+
+	```
+]=]
+function ApplicationCommand.Prototype.setDefaultPermissionEnabled(self: ApplicationCommand, enabled: boolean)
+	self.defaultPermissionEnabled = enabled
+
+	return self
+end
+
 --[=[
 	@method addContext
 	@within ApplicationCommand
@@ -213,7 +233,7 @@ end
 
 	```
 ]=]
-function ApplicationCommand.Prototype.addContext(self: ApplicationCommand, context: number): ApplicationCommand
+function ApplicationCommand.Prototype.addContext(self: ApplicationCommand, context: number)
 	table.insert(self.contexts, context)
 
 	return self
@@ -233,6 +253,7 @@ end
 ]=]
 function ApplicationCommand.Prototype.toJSONObject(self: ApplicationCommand)
 	local permissions = "0"
+	local contexts = {}
 	local options = {}
 
 	for _, commandOption in self.options do
@@ -243,17 +264,22 @@ function ApplicationCommand.Prototype.toJSONObject(self: ApplicationCommand)
 		permissions = self.commandPermissions:getValue()
 	end
 
+	for index, context in self.contexts do
+		contexts[tostring(index)] = context
+	end
+
 	return {
 		type = self.commandType,
 		name = self.commandName,
 		description = self.commandDescription,
 
 		nsfw = self.commandNSFW,
 
+		default_permission = self.defaultPermissionEnabled,
 		default_member_permissions = permissions,
 		dm_permission = self.commandDM,
 
-		contexts = self.contexts,
+		contexts = contexts,
 
 		name_localizations = self.commandLocalization,
 		description_localizations = self.commandLocalization,
@@ -291,6 +317,8 @@ export type ApplicationCommand = typeof(ApplicationCommand.Prototype) & {
 	commandType: number,
 	commandNSFW: boolean,
 
+	defaultPermissionEnabled: boolean?,
+
 	contexts: { number },
 	commandPermissions: DiscordPermissions.DiscordPermissions,
 	options: { ApplicationCommandOption.ApplicationCommandOptions }

Package/Classes/Internal/DiscordApplication.luau

@@ -1,4 +1,7 @@
 local Construct = require("../../Utils/Construct")
+local IsUnique = require("../../Utils/Dictionary/IsUnique")
+
+local EventIn = require("../Middleware/EventIn")
 
 local Future = require("../../Vendor/Future")
 
@@ -106,7 +109,26 @@ function DiscordApplication.Prototype.setSlashCommandsAsync(self: DiscordApplica
 		end
 
 		for commandId: string, command: ApplicationCommand.ApplicationCommand in commandsToUpdate do
-			self:editSlashCommandAsync(commandId, command):await()
+			local existingCommandJson
+
+			for _, commandObject in allCommands do
+				if commandObject.id == commandId then
+					existingCommandJson = commandObject
+
+					break
+				end
+			end
+
+			local existingCommandJsonClone = table.clone(existingCommandJson)
+			local existingCommandClone = self.eventInMiddleware:processJSON(command:toJSONObject() :: any)
+
+			-- fixme: contexts seem to be reported incorrectly?
+			existingCommandClone.contexts = nil
+			existingCommandJsonClone.contexts = nil
+
+			if IsUnique(existingCommandClone, existingCommandJsonClone) then
+				self:editSlashCommandAsync(commandId, command):await()
+			end
 		end
 
 		for _, command: ApplicationCommand.ApplicationCommand in commandsToCreate do
@@ -123,6 +145,8 @@ function DiscordApplication.Interface.new(discordClient: any, applicationData: {
 		return Construct({
 			id = applicationData.id,
 			flags = applicationData.flags,
+
+			eventInMiddleware = EventIn.new(),
 
 			discordClient = discordClient
 		}, DiscordApplication.Prototype)
@@ -133,6 +157,8 @@ export type DiscordApplication = typeof(DiscordApplication.Prototype) & {
 	id: string,
 	flags: number,
 
+	eventInMiddleware: EventIn.EventIn,
+
 	discordClient: any,
 }
 

Package/Utils/Dictionary/IsUnique.luau

@@ -0,0 +1,19 @@
+local IsUnique
+
+IsUnique = function(dictionary0: { [any]: any }, dictionary1: { [any]: any })
+	for key, value in dictionary0 do
+		if type(value) == "table" then
+			if IsUnique(value, dictionary1[key]) then
+				return true
+			end
+		else
+			if value ~= dictionary1[key] then
+				return true
+			end
+		end
+	end
+
+	return false
+end
+
+return IsUnique