Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): use redis to fetch locale when needed #86

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Conversation

dev-737
Copy link
Member

@dev-737 dev-737 commented Jul 20, 2024

get locale from redis or mongo when needed, instead of always setting <User>.locale. Avoids bugs

get locale from redis or mongo when needed, instead of always setting <User>.locale. Avoids bugs
Copy link

deepsource-io bot commented Jul 20, 2024

Here's the code health analysis summary for commits 4ba4c6c..01fc393. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 1 occurence introduced
🎯 4 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@dev-737 dev-737 merged commit c36f01e into v4 Jul 21, 2024
0 of 2 checks passed
@dev-737 dev-737 deleted the userLocaleCache branch July 21, 2024 15:30
dev-737 added a commit that referenced this pull request Aug 20, 2024
* feat(locale): use redis to fetch locale when needed (#86)

* feat(locale): use redis to fetch locale when needed

get locale from redis or mongo when needed, instead of always setting <User>.locale. Avoids bugs

* refactor(util): minor userLocale refactor

* refactor(decorators): decorated command methods now utilize `this` class property

* refactor(locale): type-safe locale functions

* chore: move `src/utils/RegisterCmdsCli.ts` to `scripts/deploy-commands.js`

* chore: update readme and add contributing guidelines

* ci: fix lint ci

* refactor: small scripts refactor

* refactor: move some methods from utils to userManager

* refactor: more random refactors

* refactor: use import mapping for all imports

* refactor(pagination): move pagination to its own class

* fix: resolve some eslint errors

* refactor(events): move events to seperate classes under `events/` folder

* refactor(network): refactor checks function

* refactor(basecommand): get userManager through client

* refactor(scripts): use `typescript` lib to generate types

* refactor(cache): redo cache system to be used only when required

The cache is used/called in the code instead of being used in a middleware on all queries.

* refactor(messagecreate): simplify code

* refactor(messageinfo): use collectors & improve readability

* refactor: dont sync botlist stats if clientId doesnt match

* feat: util refactors

fix #120

* refactor: antispam brainfart

* refactor(hub): improve readability of /hub moderator command

* refactor: `/hub moderator`, goal notifs, pagination refactor

* refactor: fix some deepsource errors

* fix(cache): dont cache null data

* refactor: more deepsource fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant