Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Breaking) Wrap weight and priority in an options object #78

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dmurvihill
Copy link
Contributor

Consider merging this next time you choose to publish breaking changes. It wraps the weight and priority options into a single object, preserving the same default values as before.

Users who do not pass the weight or priority arguments should be unaffected.

@DirtyHairy
Copy link
Owner

DirtyHairy commented Mar 12, 2024

After thinking about it, I'd rather overload the affected methods to allow both signatures and annotate the old signature as deprecated. This could be released immediately, and we can remove the old signature in a 0.6.0 (or maybe even 1.0.0, I think eight years are long enough for a major release 😏 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants