Skip to content

Fix grid track sizing for fit-content(percentage) and for items spanning percentage gaps #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 23, 2023
Merged

Fix grid track sizing for fit-content(percentage) and for items spanning percentage gaps #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5938e39
Add tests for child spanning two max-content tracks with gaps between…
nicoburns Jan 12, 2023
89576a9
Recompute available_grid_space and node_inner_size after initial trac…
nicoburns Jan 12, 2023
afc6560
Suspect fix WIP
nicoburns Jan 14, 2023
fba9947
Use computed column sizes for first iteration of row track size compu…
nicoburns Jan 22, 2023
7dc85fd
Don't limit the distribution of min-content sizes by the argument of …
nicoburns Jan 22, 2023
51bdf5e
Simplify fit-content tests
nicoburns Jan 22, 2023
ffb8ab1
Resolve percentage track sizing function against node_inner_size rath…
nicoburns Jan 22, 2023
5d9d4fc
Add disabled percentage fit-content test
nicoburns Jan 3, 2023
8b208f3
Percentage fit content limits WIP
nicoburns Jan 4, 2023
463bed4
Distribute growth_limit changes (broken)
nicoburns Jan 5, 2023
b557f6f
Simplify fit-content percent definite test
nicoburns Jan 22, 2023
6784f8e
Apply fit-content limit to growth limits
nicoburns Jan 22, 2023
a6afbb3
When distributing space to growth_limit use base_size as affected pro…
nicoburns Jan 22, 2023
82040cf
Add min_content and max_content variants of fit-content percent defin…
nicoburns Jan 22, 2023
3451951
Add percent indefinite fit content tests
nicoburns Jan 22, 2023
0ec28eb
Remove debug logs
nicoburns Jan 22, 2023
c60853b
Remove commented out code
nicoburns Jan 22, 2023
5e27a58
Fix clippy lints
nicoburns Jan 22, 2023
b477f32
Improve documentation of callback functions in distribute_item_space_…
nicoburns Jan 22, 2023
d023e9c
Remove useless code
nicoburns Jan 23, 2023
9c7dc89
Merge branch 'main' into grid/percent-fit-content--with-content-sizing
alice-i-cecile Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions benches/generated/grid_fit_content_percent_definite_argument.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions benches/generated/grid_fit_content_percent_definite_max_content.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions benches/generated/grid_fit_content_percent_definite_min_content.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions benches/generated/grid_fit_content_percent_indefinite_argument.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions benches/generated/grid_fit_content_percent_indefinite_max_content.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions benches/generated/grid_fit_content_percent_indefinite_min_content.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 4 additions & 12 deletions benches/generated/grid_fit_content_points_argument.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 4 additions & 12 deletions benches/generated/grid_fit_content_points_max_content.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 4 additions & 12 deletions benches/generated/grid_fit_content_points_min_content.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 46 additions & 0 deletions benches/generated/grid_max_content_single_item_span_2.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading