DioxusLabs · alice-i-cecile · Jul 25, 2022 · Jul 22, 2022 · Jul 22, 2022 · Jul 22, 2022
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -28,6 +28,10 @@ If you are developing on macOS this is easy to do through brew.
 brew install chromedriver
 ```
 
+If you are Ubuntu, you will have to install `openssl` first,
+and then can follow [these instructions](https://tecadmin.net/setup-selenium-chromedriver-on-ubuntu/).
+Be sure that your Chrome vesion matches the downloaded `chromedriver` version!
+
 Once you have chromedriver installed and available in `PATH` you can re-generate all tests by running `cargo run --package gentest`. You should not manually update the tests in `tests/generated`. Instead, fix the script in `scripts/gentest/` and re-generate them. This can happen after a refactor. It can be helpful to commit the updated tests in a dedicated commit so that they can be easier to ignore during review.
 
 To add a new test case add another HTML file to `/test_fixtures` following the current tests as a template for new tests.

diff --git a/RELEASES.md b/RELEASES.md
@@ -6,6 +6,8 @@
 
 - Added `taffy::error::InvalidChild` Error type
 - `taffy::node::Taffy.new_leaf()` which allows the creation of new leaf-nodes without having to supply a measure function
+- Builder methods are now `const` where possible
+  - Several convenenience constants have been defined: notably `FlexboxLayout::DEFAULT`
 
 ### 0.2.0 Changed
 
@@ -24,6 +26,7 @@
 - `taffy::error::InvalidChild` is now `taffy::error::TaffyError`
 - `taffy::error::InvalidNode` has been removed and is now just a branch on the `TaffyError` enum
 - `taffy::forest::Forest` has been merged into `taffy::node::Taffy` for a performance boost up to 90%
+- `Size::undefined()` has been removed, use `Size::NONE` instead.
 
 ### 0.2.0 Fixed
 

diff --git a/benches/complex.rs b/benches/complex.rs
@@ -107,7 +107,7 @@ fn taffy_benchmarks(c: &mut Criterion) {
         b.iter(|| {
             let mut taffy = taffy::node::Taffy::new();
             let root = build_deep_hierarchy(&mut taffy);
-            taffy.compute_layout(root, taffy::geometry::Size::undefined()).unwrap()
+            taffy.compute_layout(root, taffy::geometry::Size::NONE).unwrap()
         })
     });
 
@@ -117,7 +117,7 @@ fn taffy_benchmarks(c: &mut Criterion) {
 
         b.iter(|| {
             taffy.mark_dirty(root).unwrap();
-            taffy.compute_layout(root, taffy::geometry::Size::undefined()).unwrap()
+            taffy.compute_layout(root, taffy::geometry::Size::NONE).unwrap()
         })
     });
 }

diff --git a/benches/generated/absolute_layout_align_items_and_justify_content_center.rs b/benches/generated/absolute_layout_align_items_and_justify_content_center.rs
diff --git a/...s/generated/absolute_layout_align_items_and_justify_content_center_and_bottom_position.rs b/...s/generated/absolute_layout_align_items_and_justify_content_center_and_bottom_position.rs
diff --git a/...hes/generated/absolute_layout_align_items_and_justify_content_center_and_left_position.rs b/...hes/generated/absolute_layout_align_items_and_justify_content_center_and_left_position.rs
diff --git a/...es/generated/absolute_layout_align_items_and_justify_content_center_and_right_position.rs b/...es/generated/absolute_layout_align_items_and_justify_content_center_and_right_position.rs
diff --git a/benches/generated/absolute_layout_align_items_and_justify_content_center_and_top_position.rs b/benches/generated/absolute_layout_align_items_and_justify_content_center_and_top_position.rs
diff --git a/benches/generated/absolute_layout_align_items_and_justify_content_flex_end.rs b/benches/generated/absolute_layout_align_items_and_justify_content_flex_end.rs
diff --git a/benches/generated/absolute_layout_align_items_center.rs b/benches/generated/absolute_layout_align_items_center.rs
diff --git a/benches/generated/absolute_layout_align_items_center_on_child_only.rs b/benches/generated/absolute_layout_align_items_center_on_child_only.rs
diff --git a/benches/generated/absolute_layout_child_order.rs b/benches/generated/absolute_layout_child_order.rs
diff --git a/benches/generated/absolute_layout_in_wrap_reverse_column_container.rs b/benches/generated/absolute_layout_in_wrap_reverse_column_container.rs
diff --git a/benches/generated/absolute_layout_in_wrap_reverse_column_container_flex_end.rs b/benches/generated/absolute_layout_in_wrap_reverse_column_container_flex_end.rs
diff --git a/benches/generated/absolute_layout_in_wrap_reverse_row_container.rs b/benches/generated/absolute_layout_in_wrap_reverse_row_container.rs
diff --git a/benches/generated/absolute_layout_in_wrap_reverse_row_container_flex_end.rs b/benches/generated/absolute_layout_in_wrap_reverse_row_container_flex_end.rs
diff --git a/benches/generated/absolute_layout_justify_content_center.rs b/benches/generated/absolute_layout_justify_content_center.rs
diff --git a/benches/generated/absolute_layout_no_size.rs b/benches/generated/absolute_layout_no_size.rs
diff --git a/benches/generated/absolute_layout_percentage_bottom_based_on_parent_height.rs b/benches/generated/absolute_layout_percentage_bottom_based_on_parent_height.rs
diff --git a/benches/generated/absolute_layout_start_top_end_bottom.rs b/benches/generated/absolute_layout_start_top_end_bottom.rs
diff --git a/benches/generated/absolute_layout_width_height_end_bottom.rs b/benches/generated/absolute_layout_width_height_end_bottom.rs
diff --git a/benches/generated/absolute_layout_width_height_start_top.rs b/benches/generated/absolute_layout_width_height_start_top.rs
diff --git a/benches/generated/absolute_layout_width_height_start_top_end_bottom.rs b/benches/generated/absolute_layout_width_height_start_top_end_bottom.rs
diff --git a/benches/generated/absolute_layout_within_border.rs b/benches/generated/absolute_layout_within_border.rs
diff --git a/benches/generated/align_baseline.rs b/benches/generated/align_baseline.rs
diff --git a/benches/generated/align_baseline_child_multiline.rs b/benches/generated/align_baseline_child_multiline.rs
diff --git a/benches/generated/align_baseline_nested_child.rs b/benches/generated/align_baseline_nested_child.rs
diff --git a/benches/generated/align_center_should_size_based_on_content.rs b/benches/generated/align_center_should_size_based_on_content.rs
diff --git a/benches/generated/align_flex_start_with_shrinking_children.rs b/benches/generated/align_flex_start_with_shrinking_children.rs
diff --git a/benches/generated/align_flex_start_with_shrinking_children_with_stretch.rs b/benches/generated/align_flex_start_with_shrinking_children_with_stretch.rs
diff --git a/benches/generated/align_flex_start_with_stretching_children.rs b/benches/generated/align_flex_start_with_stretching_children.rs
diff --git a/benches/generated/align_items_center.rs b/benches/generated/align_items_center.rs
diff --git a/benches/generated/align_items_center_child_with_margin_bigger_than_parent.rs b/benches/generated/align_items_center_child_with_margin_bigger_than_parent.rs
diff --git a/benches/generated/align_items_center_child_without_margin_bigger_than_parent.rs b/benches/generated/align_items_center_child_without_margin_bigger_than_parent.rs
diff --git a/benches/generated/align_items_center_with_child_margin.rs b/benches/generated/align_items_center_with_child_margin.rs
diff --git a/benches/generated/align_items_center_with_child_top.rs b/benches/generated/align_items_center_with_child_top.rs
diff --git a/benches/generated/align_items_flex_end.rs b/benches/generated/align_items_flex_end.rs
diff --git a/benches/generated/align_items_flex_end_child_with_margin_bigger_than_parent.rs b/benches/generated/align_items_flex_end_child_with_margin_bigger_than_parent.rs
diff --git a/benches/generated/align_items_flex_end_child_without_margin_bigger_than_parent.rs b/benches/generated/align_items_flex_end_child_without_margin_bigger_than_parent.rs
diff --git a/benches/generated/align_items_flex_start.rs b/benches/generated/align_items_flex_start.rs
diff --git a/benches/generated/align_items_min_max.rs b/benches/generated/align_items_min_max.rs
diff --git a/benches/generated/align_items_stretch.rs b/benches/generated/align_items_stretch.rs
diff --git a/benches/generated/align_self_baseline.rs b/benches/generated/align_self_baseline.rs
diff --git a/benches/generated/align_self_center.rs b/benches/generated/align_self_center.rs
diff --git a/benches/generated/align_self_flex_end.rs b/benches/generated/align_self_flex_end.rs
diff --git a/benches/generated/align_self_flex_end_override_flex_start.rs b/benches/generated/align_self_flex_end_override_flex_start.rs
diff --git a/benches/generated/align_self_flex_start.rs b/benches/generated/align_self_flex_start.rs
diff --git a/benches/generated/align_strech_should_size_based_on_parent.rs b/benches/generated/align_strech_should_size_based_on_parent.rs
diff --git a/benches/generated/border_center_child.rs b/benches/generated/border_center_child.rs
diff --git a/benches/generated/border_flex_child.rs b/benches/generated/border_flex_child.rs
diff --git a/benches/generated/border_no_child.rs b/benches/generated/border_no_child.rs
diff --git a/benches/generated/border_stretch_child.rs b/benches/generated/border_stretch_child.rs
diff --git a/benches/generated/child_min_max_width_flexing.rs b/benches/generated/child_min_max_width_flexing.rs