Mark generated files as linguist-generated #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
suggested changes
Jun 11, 2022
Co-authored-by: François <[email protected]>
mockersf
approved these changes
Jun 11, 2022
Weibye
approved these changes
Jun 11, 2022
alice-i-cecile
added
the
build system
TimJentzsch
changed the title
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Mark generated files as lunguist-generated * Target files instead of folder in .gitattributes Co-authored-by: François <[email protected]> Co-authored-by: François <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The generated tests and benchmarks add a lot of noise when reviewing PRs.
Their diffs should be hidden by default.
Solution
This PR adds a
.gitattributefile that marks the folderstests/generatedandbenches/generatedaslinguist-generated=true. This will a) exclude them from the GitHub language stats and b) hide their diffs by default (Docs).Context
We first discussed removing the generated tests completely in #133.
However, they add a lot of value to make sure that we are fully compatible with the browser flexbox spec. Thus, they were added back with #145.
We also discussed to not commit the generated files to the repository, but generating them requires installation of
chromedriverand is a hassle for contributors.Feedback wanted
I hope this covers all generated files. I'm not completely sure if this works as I expect it to, I have never used this feature before.