Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make tensorflow,torch,zarr packages optional #135

Merged
merged 5 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build-test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
max-parallel: 2
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9"]
python-version: ["3.8", "3.9", "3.10", "3.11"]

include:
- flake8-python-git-tag: ""
Expand Down Expand Up @@ -41,7 +41,11 @@ jobs:

- name: Install histomics_stream
run: |
pip install .
pip install .[tensorflow,torch,zarr]
# With Python 3.8, tensorflow downgrades typing-extensions, which appears to
# be unnecessary and breaks a dependency of large_image, so we overrule that
# next.
pip install --upgrade typing-extensions

- name: Lint with flake8
run: |
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ sudo apt install -y python3-openslide openslide-tools
pip install histomics_stream 'large_image[openslide]' \
scikit_image --find-links https://girder.github.io/large_image_wheels
```
Note that additional image readers can be supported by using, e.g., `large_image[openslide,ometiff,openjpeg,bioformats]` instead of `large_image[openslide]`.
Additional functionality is supported with subpackages, e.g., `histomics_stream[tensorflow,torch,zarr]`. These packages are optional when histomics_stream is used only for masking and/or organizing image tiles into larger image chunks that are more efficient to read than individual image tiles. However, if you are creating a tensorflow `Dataset` or a pytorch `DataLoader` then you will need the corresponding packages.

Additional image readers can be supported by using, e.g., `large_image[openslide,ometiff,openjpeg,bioformats]` instead of `large_image[openslide]`.

After launching `python3`, import the `histomics_stream` package with:

Expand Down
2 changes: 1 addition & 1 deletion example/pytorch_stream.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"!apt update\n",
"!apt install -y python3-openslide openslide-tools\n",
"!pip install 'large_image[openslide,tiff]' --find-links https://girder.github.io/large_image_wheels\n",
"!pip install histomics_stream\n",
"!pip install histomics_stream[torch]\n",
"\n",
"# Get other packages used in this notebook\n",
"# N.B. itkwidgets works with jupyter<=3.0.0\n",
Expand Down
2 changes: 1 addition & 1 deletion example/tensorflow_stream.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"!apt update\n",
"!apt install -y python3-openslide openslide-tools\n",
"!pip install 'large_image[openslide,tiff]' --find-links https://girder.github.io/large_image_wheels\n",
"!pip install histomics_stream\n",
"!pip install histomics_stream[tensorflow]\n",
"\n",
"# Get other packages used in this notebook\n",
"# N.B. itkwidgets works with jupyter<=3.0.0\n",
Expand Down
10 changes: 5 additions & 5 deletions histomics_stream/configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
import re

import itk
import large_image
import large_image_source_tiff
import numpy as np
import scipy.interpolate

Expand Down Expand Up @@ -185,7 +183,6 @@ def __call__(self, slide):

# Do the work.
if not re.compile(r"\.zarr$").search(filename):

# create large_image, prioritizing tiff source over openslide
try:
import large_image_source_tiff
Expand Down Expand Up @@ -592,7 +589,7 @@ def __call__(self, slide):
if 0 <= self.randomly_select < len(slide["tiles"]):
# Choose a subset of the tiles randomly
slide["tiles"] = dict(
random.sample(slide["tiles"].items(), self.randomly_select)
random.sample(sorted(slide["tiles"].items()), self.randomly_select)
)

def check_mask_filename(self, mask_filename):
Expand Down Expand Up @@ -809,7 +806,7 @@ def __call__(self, slide):
if 0 <= self.randomly_select < len(slide["tiles"]):
# Choose a subset of the tiles randomly
slide["tiles"] = dict(
random.sample(slide["tiles"].items(), self.randomly_select)
random.sample(sorted(slide["tiles"].items()), self.randomly_select)
)


Expand Down Expand Up @@ -1060,6 +1057,9 @@ def read_large_image(
# ChunkLocations.read_large_image._num_chunks += 1

# print(f"{chunk_name} begin {datetime.datetime.now()}")
import large_image
import large_image_source_tiff

ts = (
large_image_source_tiff.open(filename)
if os.path.splitext(filename)[1] in (".tif", ".tiff", ".svs")
Expand Down
13 changes: 11 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,28 @@ readme = "README.md"
requires-python = ">=3.6"
authors = [{name = "Lee A. Newberg", email = "[email protected]"}]
maintainers = [{name = "Lee A. Newberg", email = "[email protected]"}]
keywords = ["tensorflow", "whole slide image", "stream", "machine learning"]
keywords = ["tensorflow", "torch", "whole slide image", "stream", "machine learning"]
classifiers = ["License :: OSI Approved :: Apache Software License"]
dependencies = [
"imagecodecs",
"itk",
"numcodecs",
"numpy",
"scipy",
]
dynamic = ["version", "description"]

[project.optional-dependencies]
tensorflow = [
"tensorflow<3.0.0",
"keras",
]
torch = [
"torch<2.0.0",
]
zarr = [
"zarr",
]
dynamic = ["version", "description"]

[project.urls]
Source = "https://github.com/DigitalSlideArchive/HistomicsStream"
Expand Down
7 changes: 3 additions & 4 deletions test/test_mask.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ def test_mask_threshold():
wsi_path = pooch.retrieve(
fname="TCGA-AN-A0G0-01Z-00-DX1.svs",
url=(
"https://drive.google.com/uc"
"https://drive.usercontent.google.com/download"
"?export=download"
"&id=19agE_0cWY582szhOVxp9h3kozRfB4CvV"
"&confirm=t"
"&uuid=6f2d51e7-9366-4e98-abc7-4f77427dd02c"
"&at=ALgDtswlqJJw1KU7P3Z1tZNcE01I:1679111148632"
),
known_hash="d046f952759ff6987374786768fc588740eef1e54e4e295a684f3bd356c8528f",
path=str(pooch.os_cache("pooch")) + os.sep + "wsi",
Expand All @@ -43,9 +41,10 @@ def test_mask_threshold():
mask_path = pooch.retrieve(
fname="TCGA-AN-A0G0-01Z-00-DX1.mask.png",
url=(
"https://drive.google.com/uc"
"https://drive.usercontent.google.com/download"
"?export=download"
"&id=17GOOHbL8Bo3933rdIui82akr7stbRfta"
"&confirm=t"
),
known_hash="bb657ead9fd3b8284db6ecc1ca8a1efa57a0e9fd73d2ea63ce6053fbd3d65171",
path=str(pooch.os_cache("pooch")) + os.sep + "wsi",
Expand Down
Loading