Skip to content

Add snapShot test for dialog component #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FacuRossi
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hbowden
Copy link
Contributor

hbowden commented Oct 17, 2018

@FacuRossi Thanks for the pr! It looks good from looking at the diff. I'll pull it down and test it and merge in like 15 or 20 minutes I'm just finishing something up. Thanks again for the work.

@Darper
Copy link
Contributor

Darper commented Oct 17, 2018

Hi @FacuRossi. Can you sign the CLA? We'll need it to merge your contribution. Thanks!

@Darper
Copy link
Contributor

Darper commented Oct 17, 2018

Also, children is a required property for Dialog. Please add some example children to make your new test pass then update your snapshot file using npm run updateSnapshot.

@Darper
Copy link
Contributor

Darper commented Nov 13, 2018

The snapshot test is still failing. children are required, so won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants