Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed text outline! #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed text outline! #13

wants to merge 4 commits into from

Conversation

evan-lauer
Copy link
Contributor

Closes #10

@apjmason
Copy link
Member

Hey @evan-lauer this is a good thought but needs some work. First, you've changed the functionality to supply the "#" before the hex value, but that goes against the help text that asks users to supply the value with #, and also breaks the ability to use CSS color names.

More importantly, I think we should change this to just override the color of the default outline property, rather than resetting outline and adding a border (which distorts the content in many containers).

@evan-lauer
Copy link
Contributor Author

Oops! I see that.

Maybe it makes sense to add color presets as the first option for the developer, then as an "advanced setting", let the developer choose their own color? That way the developer doesn't have to google a hex color picker?

As for the second bit, yes you're right. I'll change that back.

@evan-lauer evan-lauer closed this Mar 3, 2022
@apjmason
Copy link
Member

apjmason commented Mar 3, 2022

Hi Evan, let's keep this branch open and have you address the point above in it to preserve the comment history. Just push new commits to this branch and it'll update this PR.

@apjmason apjmason reopened this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard Focus Outlines not functional
2 participants