-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving Eslint Errors #634
Draft
FutzMonitor
wants to merge
13
commits into
DickinsonCollege:main
Choose a base branch
from
FarmData-2-Dev-Team-2022:Issue600_EslintErrors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Resolving Eslint Errors #634
FutzMonitor
wants to merge
13
commits into
DickinsonCollege:main
from
FarmData-2-Dev-Team-2022:Issue600_EslintErrors
Commits on Mar 7, 2023
-
- Added the creation of the .eslintignore file which is used to ignore the linting of javascript files. 2. Changes to test_runner.bash - Indentation fixes
Configuration menu - View commit details
-
Copy full SHA for 093e9ad - Browse repository at this point
Copy the full SHA 093e9adView commit details
Commits on Mar 17, 2023
-
- Created an eslintignore file that ignores the Cypress tests
Configuration menu - View commit details
-
Copy full SHA for 00b6b2d - Browse repository at this point
Copy the full SHA 00b6b2dView commit details
Commits on Mar 25, 2023
-
- Added a line to ignore the .eslintignore. 2. Changes to the dev/Dockerfile - Copied the .eslint file inside the docker/dev directory into the container. Built the container locally, and this did the trick. - Unfortunately, I couldn't get Cypress to work on my machine to be able to verify that it works on the host machine. You only need one .eslintignore file, and it might be that the one in the docker/dev directory is good enough.
Configuration menu - View commit details
-
Copy full SHA for 7553901 - Browse repository at this point
Copy the full SHA 7553901View commit details
Commits on Mar 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 88557fc - Browse repository at this point
Copy the full SHA 88557fcView commit details -
- Making sure the .eslintignore file remained hidden
Configuration menu - View commit details
-
Copy full SHA for 0d796d2 - Browse repository at this point
Copy the full SHA 0d796d2View commit details -
- Realized that ignoring the .eslintignore is NOT what we want. We want it to be included in the project. 2. Addition of the dev/.eslintignore file - File that prevents eslint from running on js files.
Configuration menu - View commit details
-
Copy full SHA for 5adf257 - Browse repository at this point
Copy the full SHA 5adf257View commit details
Commits on Mar 28, 2023
-
- Moved the new COPY command below line 187 w/explaination for its existence
Configuration menu - View commit details
-
Copy full SHA for c40fa04 - Browse repository at this point
Copy the full SHA c40fa04View commit details -
1. Renamed dev/.eslintignore to dev/eslintignore
2. Changes to dev/Dockerfile - Changed the COPY command to make the visible eslintignore file invisible inside the dev container
Configuration menu - View commit details
-
Copy full SHA for 3fb36b0 - Browse repository at this point
Copy the full SHA 3fb36b0View commit details
Commits on Apr 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c66373d - Browse repository at this point
Copy the full SHA c66373dView commit details
Commits on Apr 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97eef8b - Browse repository at this point
Copy the full SHA 97eef8bView commit details -
Merge branch 'Issue600_EslintErrors' of https://github.com/FarmData-2…
…-Dev-Team-2022/FarmData2 into Issue600_EslintErrors
Configuration menu - View commit details
-
Copy full SHA for 845835f - Browse repository at this point
Copy the full SHA 845835fView commit details
Commits on May 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0c16482 - Browse repository at this point
Copy the full SHA 0c16482View commit details
Commits on May 2, 2023
-
- somehow my changes were removed from my system. I had to add these files back before working. No changes here besides incorporating the stylesheet. Changes to BCalendarDateSelection.js - no noteable changes. Could not figure out how to make BCalendar work. Changes to BCalendarDateSelection.spec.comp.js - No noteable changes. Basically the same.
Configuration menu - View commit details
-
Copy full SHA for 9ef0d4a - Browse repository at this point
Copy the full SHA 9ef0d4aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.