-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auth support with dockerfile #15
Conversation
@lucifercr07, have a look |
added a comment @vinitparekh17 . Hey @vinitparekh17 can you also go ahead and add the docker-compose file that builds the BE depending on DiceDB image: https://hub.docker.com/r/dicedb/dicedb as DB dependency. You already have Dockerfile in place that LGTM! 👍 |
done |
docker-compose.yml
Outdated
depends_on: | ||
- dicedb | ||
environment: | ||
- DICE_ADDR=dicedb:7379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use DICEDB
everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pardon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he means the naming convention is dicedb and not dice.
like below:
environment:
- DICEDB_ADDR=dicedb:7379
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README with details around docker compose.
it's just a basic cmd |
@vinitparekh17 we need documention around docker-compose as oppose to the people setting up this repo can just read the ReadMe.md file and do it. let me know if you need any help around it. |
26160fc
to
1f4f1c6
Compare
done |
1f4f1c6
to
73444bf
Compare
ready for review |
|
@vinitparekh17 apologies for delay, will review it by tomorrow EOD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments.
Please resolve conflicts.
Also the backend container is failing on spawn, please check once.
|
73444bf
to
751f675
Compare
done |
5b8d6e5
to
bec8e9b
Compare
issue ref |
@vinitparekh1 can you add the detailed steps in README, would be helpful for folks working on project. |
23f075c
to
dd6a5c3
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix minor comments.
.env.example
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we rename it to .env.sample
same as README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
dd6a5c3
to
c8e8a85
Compare
5cb9087
to
e3d733c
Compare
@lucifercr07 can you perform |
@vinitparekh17 had fixed it as part of my earlier commit, please check master build it's green. |
This PR ensures that dicedb will be used with proper username and password to ensure security