Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auth support with dockerfile #15

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

vinitparekh17
Copy link
Contributor

This PR ensures that dicedb will be used with proper username and password to ensure security

@vinitparekh17
Copy link
Contributor Author

@lucifercr07, have a look

config/config.go Outdated Show resolved Hide resolved
@rishavvajpayee
Copy link
Contributor

added a comment @vinitparekh17 .

Hey @vinitparekh17 can you also go ahead and add the docker-compose file that builds the BE depending on DiceDB image: https://hub.docker.com/r/dicedb/dicedb as DB dependency. You already have Dockerfile in place that LGTM! 👍

@vinitparekh17
Copy link
Contributor Author

added a comment @vinitparekh17 .

Hey @vinitparekh17 can you also go ahead and add the docker-compose file that builds the BE depending on DiceDB image: https://hub.docker.com/r/dicedb/dicedb as DB dependency. You already have Dockerfile in place that LGTM! 👍

done

depends_on:
- dicedb
environment:
- DICE_ADDR=dicedb:7379
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use DICEDB everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pardon?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he means the naming convention is dicedb and not dice.
like below:
environment:
- DICEDB_ADDR=dicedb:7379

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README with details around docker compose.

@vinitparekh17
Copy link
Contributor Author

Please update the README with details around docker compose.

it's just a basic cmd docker compose up what to write about that?

@rishavvajpayee
Copy link
Contributor

@vinitparekh17 we need documention around docker-compose as oppose to the people setting up this repo can just read the ReadMe.md file and do it. let me know if you need any help around it.

@vinitparekh17
Copy link
Contributor Author

@vinitparekh17 we need documention around docker-compose as oppose to the people setting up this repo can just read the ReadMe.md file and do it. let me know if you need any help around it.

done

@vinitparekh17
Copy link
Contributor Author

ready for review

@vinitparekh17
Copy link
Contributor Author

ready for review

@lucifercr07 @rishavvajpayee

@lucifercr07
Copy link
Contributor

@vinitparekh17 apologies for delay, will review it by tomorrow EOD.

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments.
Please resolve conflicts.

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@lucifercr07
Copy link
Contributor

Also the backend container is failing on spawn, please check once.

backend-1  | Warning: .env file not found, falling back to system environment variables.
dicedb-1   | 2024/10/09 17:43:52 INFO DiceDB 0.0.4 running on port 7379
dicedb-1   | 2024/10/09 17:43:52 INFO HTTP Server running on Port:8082
dicedb-1   | 2024/10/09 17:43:52 WARN WARNING: DiceDB is running without authentication. Consider setting a password.
backend-1  | 2024/10/09 17:43:55 ERROR Failed to initialize DiceDB client: %v err="dial tcp 127.0.0.1:7379: connect: connection refused"
backend-1 exited with code 1

@vinitparekh17
Copy link
Contributor Author

LGTM, minor comments. Please resolve conflicts.

done

docker-compose.yml Show resolved Hide resolved
@vinitparekh17 vinitparekh17 force-pushed the dockerfile branch 2 times, most recently from 5b8d6e5 to bec8e9b Compare October 17, 2024 09:04
@vinitparekh17
Copy link
Contributor Author

issue ref

@lucifercr07
Copy link
Contributor

issue ref

@vinitparekh1 can you add the detailed steps in README, would be helpful for folks working on project.

@vinitparekh17
Copy link
Contributor Author

issue ref

@vinitparekh1 can you add the detailed steps in README, would be helpful for folks working on project.

done

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix minor comments.

.env.example Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we rename it to .env.sample same as README?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated Show resolved Hide resolved
@lucifercr07 lucifercr07 merged commit 62d5d90 into DiceDB:master Oct 18, 2024
2 checks passed
@vinitparekh17
Copy link
Contributor Author

@lucifercr07 can you perform HGETALL test cases manually into dicedb coz i think db has some issues with that cmd

@lucifercr07
Copy link
Contributor

@vinitparekh17 had fixed it as part of my earlier commit, please check master build it's green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants