Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit and make documentation for command SCARD consistent #989

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Audit and make documentation for command SCARD consistent #989

merged 1 commit into from
Oct 7, 2024

Conversation

sahibamatta
Copy link
Contributor

This PR fixes #790

Changes

  • Updated the titles to match the strings as specified in the issue .
  • Created markdown tables for Parameters and Return Values
  • Re-order the pointers in Behaviour section to be aligned with Return values section.
  • Reformatted Errors section and added a new error
  • Updated CLI prompt to 127.0.0.1:7379>
  • Added a new Error Example for Wrong Argument

@sahibamatta
Copy link
Contributor Author

Hi @lucifercr07, @arpitbbhayani could you please review? Thanks!

@lucifercr07 lucifercr07 merged commit 6deadb2 into DiceDB:master Oct 7, 2024
1 check passed
sashpawar11 pushed a commit to sashpawar11/dice that referenced this pull request Oct 13, 2024
@sahibamatta @sashpawar11
DiceDB#790: Update SCARD doc (DiceDB#989)
efd7dad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucifercr07 lucifercr07 lucifercr07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit and make documentation for command SCARD consistent
2 participants
@sahibamatta @lucifercr07