Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#933: fix: Fixes output of LPUSH command #971

Closed

Conversation

Aditya-Chowdhary
Copy link
Contributor

Fixes #933 by returning the length instead of OK.

Minor side change - Integration test for RPUSH used LPUSH command like below, which was fixed

cmds: []string{"LPUSH k v", "LPUSH k v1 1 v2 2", "LPUSH k 3 3 3 v3 v3 v3"},

Would also like to point out the existence of a duplicate issue #961

Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for contributing to DiceDB. I have the following suggestions :

  1. During the type and encoding check, I think we can remove the check for set data, as we are doing that in the next check anyway. I did some changes in the local for this PR and it was working as expected. However, please test the changes and add scenarios in the tests.
  2. We can add more test cases for errors. I could not find much test cases for error, especially when the key is of type set, hmap, json, etc.
    With these suggestions I believe, we will be increasing test coverage for this command.

Thanks.

@lucifercr07
Copy link
Contributor

Closing, merged as part of #969

@lucifercr07 lucifercr07 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent LPUSH: Command returns OK instead of Integer(length of list)
3 participants