docs: Add Arity Error Documentation to GETBIT #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvyadav1111
requested changes
Oct 5, 2024
There was a problem hiding this comment.
Hi, thanks for the contribution. I have few suggestions that I would like to share. In the return values table, we can convey the information in a better way as we are distinguishing command is successful and key not existing as separate. However, key not existing or key length less than offset both are considered to be successful operation.
In addition to this, in the explanation we can also add about the value at offset being considered 0 if the length is less than offset .
I think the rest of the document is complete.
Thanks
|
@apoorvyadav1111 I have updated the doc as such. Thanks for the review. |
apoorvyadav1111
approved these changes
Oct 6, 2024
sashpawar11
pushed a commit
to sashpawar11/dice
that referenced
this pull request
Oct 13, 2024
* docs: Add Arity Error Documentation to GETBIT fixes: DiceDB#796 * fixup! docs: Add Arity Error Documentation to GETBIT * fixup! fixup! docs: Add Arity Error Documentation to GETBIT * fixup! fixup! fixup! docs: Add Arity Error Documentation to GETBIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #796