feat: Implement GEOADD and GEODIST commands #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaviiSuri
force-pushed
the
kavii/geohash-implementation
branch
from
12f0d7b to
280f7c1
Compare
KaviiSuri
force-pushed
the
kavii/geohash-implementation
branch
from
280f7c1 to
5b6d4d7
Compare
|
Let's keep our calculations consistent with redis for now. |
JyotinderSingh
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Thanks for this massive effort @KaviiSuri! The changes look well written and well tested. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZADDandZRANGEimplementation into thesortedsetpackage, allowing use in other commandsGEOADDandGEODISTcommands, that use geohash (from github.com/mmcloughlin/geohash) and sorted set implementation to implement geo spatial indexes.geopackage that contains geospatial calculations and abstracts the library so we can modify/swap it out later.NOTE: for the sake of being consistent with redis, i've set the geohash precision to 52 bits, it kinda seems wasteful since we anyway store 64 bites. Do you think it's better to use all 64 bits? doing so will make our distances a bit different from redis output (in my tests about 0.128% -> 20cm in 166 KM)