Eval Refactor for the better compatibility with all protocols and multithreading #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not required! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements and refactoring related to the handling of command responses in our system.
(Note: This change may break many test cases that use GET, SET, and GETSET because now responses are raw typed and not the encoded ones. We need to figure out a way to fix these cases)
The key enhancements are as follows:
Migration of Command Responses:
The Eval Response mechanism has been updated to ensure that responses are returned in an unencoded format. This modification allows various protocols, including RESP, HTTP, and WebSocket, to flexibly convert and format the response as required before sending it to the client. This change not only standardizes response handling across different communication channels but also enhances the interoperability of our system.
Improved Error Handling:
Error responses have been streamlined and formulated to provide clearer and more consistent messaging. This enhancement aims to improve the debugging experience and ensure that clients receive informative and actionable error responses. By adopting a standardized format for errors, we can facilitate better protocol-based error handling
Efficiency in Response Management:
The handling of responses from the Eval function has been optimized by ensuring that responses are returned by reference rather than as values. This change eliminates the unnecessary copying of response data throughout the lifecycle of a command, resulting in improved performance and reduced memory overhead.
Foundation for Future Migrations:
This pull request lays the groundwork for the ongoing migration of all command responses to the new handling mechanism. By implementing these changes now, we establish a consistent and scalable approach that will facilitate the gradual migration of additional commands in subsequent iterations. This strategic move will help in creating a more robust and maintainable codebase moving forward.