#653: Added HSCAN command #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JyotinderSingh @lucifercr07 Can you review it and approve if it looks good? |
manishrw
force-pushed
the
feature/commands/hscan
branch
from
ec4e0d0 to
c580d62
Compare
|
@JyotinderSingh @lucifercr07 Can you review and approve this PR? |
JyotinderSingh
requested changes
Oct 5, 2024
There was a problem hiding this comment.
Thanks for adding support for HSCAN command @manishrw! Left a few comments.
|
@JyotinderSingh I've addressed the comments. |
JyotinderSingh
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Thanks for adding support for HSCAN command and updating the docs, @manishrw! Changes look good and well-tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Issue: #653