Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval Refactor for the better compatibility with all protocols and multithreading #766

Merged
merged 47 commits into from
Oct 2, 2024

Conversation

AshwinKul28
Copy link
Contributor

This pull request introduces significant improvements and refactoring related to the handling of command responses in our system.

(Note: This change may break many test cases that use GET, SET, and GETSET because now responses are raw typed and not the encoded ones. We need to figure out a way to fix these cases)


The key enhancements are as follows:

Migration of Command Responses:

The Eval Response mechanism has been updated to ensure that responses are returned in an unencoded format. This modification allows various protocols, including RESP, HTTP, and WebSocket, to flexibly convert and format the response as required before sending it to the client. This change not only standardizes response handling across different communication channels but also enhances the interoperability of our system.

Improved Error Handling:

Error responses have been streamlined and formulated to provide clearer and more consistent messaging. This enhancement aims to improve the debugging experience and ensure that clients receive informative and actionable error responses. By adopting a standardized format for errors, we can facilitate better protocol-based error handling

Efficiency in Response Management:

The handling of responses from the Eval function has been optimized by ensuring that responses are returned by reference rather than as values. This change eliminates the unnecessary copying of response data throughout the lifecycle of a command, resulting in improved performance and reduced memory overhead.

Foundation for Future Migrations:

This pull request lays the groundwork for the ongoing migration of all command responses to the new handling mechanism. By implementing these changes now, we establish a consistent and scalable approach that will facilitate the gradual migration of additional commands in subsequent iterations. This strategic move will help in creating a more robust and maintainable codebase moving forward.

@AshwinKul28
Copy link
Contributor Author

@soumya-codes @pratikpandey21 @JyotinderSingh @lucifercr07 Please have a look!

Copy link
Contributor

@pratikpandey21 pratikpandey21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left 2 small comments.

internal/server/httpServer.go Show resolved Hide resolved
internal/server/server.go Show resolved Hide resolved
Copy link
Contributor

@soumya-codes soumya-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshwinKul28 thanks for working on these changes. I have left a few comments for me to understand the code changes better.

internal/server/httpServer.go Show resolved Hide resolved
internal/server/server.go Show resolved Hide resolved
internal/clientio/iohandler/netconn/netconn.go Outdated Show resolved Hide resolved
@lucifercr07 lucifercr07 merged commit a63698e into DiceDB:master Oct 2, 2024
2 checks passed
This was referenced Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants