Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1387: Remove validator field from evalTestCase. #1400

Merged
merged 2 commits into from
Dec 26, 2024
Merged

#1387: Remove validator field from evalTestCase. #1400

merged 2 commits into from
Dec 26, 2024

Conversation

c-harish
Copy link
Contributor

PR removes validator function fields in evalTestCase struct and all existing validators are moved to use newValidator func field.

Closes #1387

@c-harish
Copy link
Contributor Author

Hi, @lucifercr07. Please review.
Thanks

lucifercr07
lucifercr07 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @c-harish for contributing.

@lucifercr07 lucifercr07 merged commit b39869c into DiceDB:master Dec 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucifercr07 lucifercr07 lucifercr07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of validator function in eval_test.go
2 participants
@c-harish @lucifercr07