-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#964 Support for OBJECT ENCODING #1039
Conversation
Hi @lucifercr07 @JyotinderSingh @apoorvyadav1111 - have added the new changes in this PR based on the comments in the old PR. Thankyou. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I ran tests in my local and I can see we are not running a cleanup after test cases. While individual tests might not be affected, running the whole suite without clean up can lead to failure. You can use defer at the start of the function along with FLUSHDB or choose to individually run cleanup after individual tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me. Approved 🚀
This PR adds support for
OBJECT ENCODING
and closes #964This PR consists of additional updates suggested on the previous PR #977 and supersedes it.
Changes :
OBJECT ENCODING
subcommand, supporting the relevant encoding types available in dicedb.Note:
Supported Object Types and Object Encoding: