Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of validator function in eval_test.go #1387

Closed
lucifercr07 opened this issue Dec 20, 2024 · 4 comments · Fixed by #1400
Closed

Remove usage of validator function in eval_test.go #1387

lucifercr07 opened this issue Dec 20, 2024 · 4 comments · Fixed by #1400
Assignees
Labels
good first issue Good for newcomers

Comments

@lucifercr07
Copy link
Contributor

Issue:

  • We've migrated all the commands to new eval format, however we still have few unit test cases still using old output format.
    image

As part of this issue:

  1. Analyse the references of validator func(output []byte) in evalTestCase struct.
  2. Remove the reference and update the test cases to implement newValidator func(output interface{})
  3. If all the references are removed, we can delete the validator func(output []byte) from evalTestCase struct.
@lucifercr07 lucifercr07 added the good first issue Good for newcomers label Dec 20, 2024
@c-harish
Copy link
Contributor

@lucifercr07, Can i pick this up?

@lucifercr07
Copy link
Contributor Author

@c-harish assigned, thanks for contributing.

@ChetanNagane
Copy link

Hi @c-harish i believe you already have issue in your hand #1250 can you please let me take up this issue.

@c-harish
Copy link
Contributor

Hi @c-harish i believe you already have issue in your hand #1250 can you please let me take up this issue.

Hi, @ChetanNagane. I have a blocker on #1250. So went ahead with his one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants