FIX: Delete Command with 0 Arguments (#985)

DiceDB · Oct 6, 2024 · e2990b5 · e2990b5
1 parent 6abbe37
commit e2990b5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/integration_tests/commands/async/del_test.go b/integration_tests/commands/async/del_test.go
@@ -30,6 +30,11 @@ func TestDel(t *testing.T) {
 			commands: []string{"GET k3", "DEL k3"},
 			expected: []interface{}{"(nil)", int64(0)},
 		},
+		{
+			name:     "DEL with no keys or arguments",
+			commands: []string{"DEL"},
+			expected: []interface{}{"ERR wrong number of arguments for 'del' command"},
+		},
 	}
 
 	for _, tc := range testCases {
@@ -45,4 +50,4 @@ func TestDel(t *testing.T) {
 			}
 		})
 	}
-}
+}
diff --git a/internal/eval/eval.go b/internal/eval/eval.go
@@ -1640,6 +1640,10 @@ func evalTTL(args []string, store *dstore.Store) []byte {
 func evalDEL(args []string, store *dstore.Store) []byte {
 	var countDeleted = 0
 
+	if len(args) < 1 {
+		return diceerrors.NewErrArity("DEL")
+	}
+
 	for _, key := range args {
 		if ok := store.Del(key); ok {
 			countDeleted++

diff --git a/internal/eval/eval_test.go b/internal/eval/eval_test.go
@@ -1937,12 +1937,12 @@ func testEvalDel(t *testing.T, store *dstore.Store) {
 		"nil value": {
 			setup:  func() {},
 			input:  nil,
-			output: []byte(":0\r\n"),
+			output: clientio.Encode(errors.New("ERR wrong number of arguments for 'del' command"), false),
 		},
 		"empty array": {
 			setup:  func() {},
 			input:  []string{},
-			output: []byte(":0\r\n"),
+			output: clientio.Encode(errors.New("ERR wrong number of arguments for 'del' command"), false),
 		},
 		"key does not exist": {
 			setup:  func() {},