Add type annotations #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hi! Anything else to do to merge this? |
|
Hi @Diaoul 👋 , can this be merged already? |
|
I'm not sure why tests are not passing on the CI 🤔 |
|
Don't they pass after the last commit of the PR fe98cf4 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also lint and format with ruff (using
subliminalsettings inpyproject.toml).I corrected (only!) one bug that appeared when adding types:
babelfish/babelfish/converters/opensubtitles.py
Line 30 in 1d7d414
changed to
So the return type is coherent.
Tests are passing but it would be better to test with another package (like
subliminal) if it doesn't introduce bugs/differences.