Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests #120

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

stufisher
Copy link
Contributor

Tests are now found via entry points. Also added a pytest style -k to filter tests.
Probably need a config option to disable certain tests, for example once switched to rabbitmq we won't want to run the activemq test.

@Anthchirp
Copy link
Contributor

I would suggest waiting with this until after RabbitMQ is deployed and support for ActiveMQ is deprecated/removed.
The reason for this is not just the ActiveMQ-specific test, but also that the overall layout of tests may change, eg. other ActiveMQ specific bits will fall away (time.sleep) and the transient. queue namespace will no longer be a thing.

Copy link
Contributor

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, I'm not hostile to adding this if you're fine with it being completely rewritten later.
I would suggest though to rename the command to zocalo.run_system_tests to match dlstbx and give a stronger sense of what this is about.

@Anthchirp
Copy link
Contributor

Note: The original agreement was that this wouldn't go into the zocalo package, but into zocalo-dls.

@stufisher
Copy link
Contributor Author

I think its useful outside of dls? I already have this running like you on a 30 min basis to test various services.

I keep the esrf specific system tests in an esrf repo (i.e. we have our own file watcher), but i think the general code is useful to all sites?

@stufisher
Copy link
Contributor Author

md converted to rst, cli tool renamed

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 5, 2021

This pull request introduces 1 alert when merging c928650 into 702d3fc - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants