Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I24 ssx test hotfixes #59

Merged
merged 6 commits into from
Nov 16, 2023
Merged

I24 ssx test hotfixes #59

merged 6 commits into from
Nov 16, 2023

Conversation

noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Nov 14, 2023

  • Wrong PV name
  • Set up and enum or something to look up what detector is requested. The choice on the edm will set the value to 0/1 instead of eiger/pilatus ( -> follow up to this: set up something similar for map_type and chip_type)
  • Temporary fix for log permission issue
  • OAV only uses crosshair from zoom 1.0, on I24 this is not updated beyond this line, so simply set that level for moveonclick

For Viewer/OAVParams issue see #44

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f6c086e) 47.92% compared to head (83d2d7a) 47.91%.

Files Patch % Lines
src/mx_bluesky/I24/serial/log.py 40.00% 3 Missing ⚠️
...esky/I24/serial/fixed_target/i24ssx_moveonclick.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   47.92%   47.91%   -0.02%     
==========================================
  Files          21       21              
  Lines        3309     3308       -1     
==========================================
- Hits         1586     1585       -1     
  Misses       1723     1723              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noemifrisina noemifrisina requested a review from d-perl November 15, 2023 18:58
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@noemifrisina noemifrisina merged commit 9e30dd0 into main Nov 16, 2023
15 of 16 checks passed
@noemifrisina noemifrisina deleted the i24ssx-hotfixes-141123 branch November 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants