Choose the detector to use and move the detector stage #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 47.56% 47.92% +0.36%
==========================================
Files 19 21 +2
Lines 3267 3309 +42
==========================================
+ Hits 1554 1586 +32
- Misses 1713 1723 +10
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
d-perl
suggested changes
Nov 10, 2023
| def setup_detector_stage(detector_stage: DetectorMotion, expt_type: str): | ||
| # Grab the correct PV depending on experiment | ||
| # Its value is set with MUX on edm screen | ||
| det_type = pv.me14e_gp101 if expt_type == "fixed-target" else pv.ioc12_gp15 |
There was a problem hiding this comment.
Should: can we use the SSXType enum for this?
|
|
||
| def get_detector_type() -> Detector: | ||
| det_y = caget(pv.det_y) | ||
| # Note to self, I should also be able to use detmotion for this too! |
There was a problem hiding this comment.
Should: please expand into an issue and link it so that someone else could fix this, or remove
| parser.add_argument( | ||
| "expt", | ||
| type=str, | ||
| choices=["extruder", "fixed-target"], |
There was a problem hiding this comment.
you should be able to parse directly to SSXType enum here if the string choices match the enum values
d-perl
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Adds a small plan to move the detector stage to the correct position depending on the requested detector to use.
Also add the edm screens for fixed-target and extruder to trigger it.