Use ruff as a linter #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 46.88% 46.88%
=======================================
Files 19 19
Lines 3242 3242
=======================================
Hits 1520 1520
Misses 1722 1722
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
previously requested changes
Nov 2, 2023
There was a problem hiding this comment.
Great, thank you. Minor comment. Could you add DiamondLightSource/dodal@b980f9b in to this PR too so that the CI is working?
|
|
||
| # A dictionary of graphviz graph attributes for inheritance diagrams. | ||
| inheritance_graph_attrs = dict(rankdir="TB") | ||
| inheritance_graph_attrs = {"rankdir": "TB"} | ||
|
|
||
| # Common links that should be available on every page | ||
| rst_epilog = """ |
There was a problem hiding this comment.
Could: The links to flake8 and isort links here aren't needed
d-perl
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53 .
Replace isort/flake8 in pre-commits with Ruff.
Also pin builds to 3.11 as p4p doesn't build in 3.12 (stop docs from failing)