-
Notifications
You must be signed in to change notification settings - Fork 5
Add testing for fast grid scan without grid detect #752
Conversation
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 37 37
Lines 1808 1808
=======================================
Hits 1703 1703
Misses 105 105 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good test but I think we should change it slightly as in comment
RE(bps.stage(fake_fgs_composite.eiger)) | ||
fake_fgs_composite.eiger.arming_status.wait(60) | ||
fake_fgs_composite.eiger._wait_fan_ready.assert_called_once() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must: I think the test needs to assert that after the stage
we're armed without needing to do a wait (to get it consistent we may need one of the mock sets to take some fraction of time)
bc53f97
to
5a670b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you
Fixes #686
Link to dodal PR (if required): DiamondLightSource/dodal#92
The unit test seems to work but takes a long time to complete for some reason
To test:
Confirm unit test is sensible