This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Speed up unit tests and fix some typing issues #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytest flag that didn't seem to do anything
dperl-dls
changed the title
dperl-dls
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
But it's fine, I just updated the title to match
There was a problem hiding this comment.
It's not completely unrelated, stopping test_given_detector_bit_depth_changes_then_vds_datatype_as_expected from file writing/reading sped up the tests by ~3 seconds. But I felt we should have something to test that vds was being written vaguely correctly so put it in test_rotation_scan_nexus_output_compared_to_existing_file (which we maybe could argue should be a system test as it takes a couple of seconds and depends on:
Nexgencode- Reading/writing from the filesystem
There was a problem hiding this comment.
Oh, you meant the typing issue? Sure, slightly unrelated, just leaving the code better than I found it
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1220_slow_unit_tests Speed up unit tests and fix some typing issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1220
To test:
pytest -m "not s03", confirm they all pass in ~30s