Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Use proper beamline name in nexus #1140

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

DominicOram
Copy link
Collaborator

@DominicOram DominicOram commented Feb 8, 2024

Fixes #1139

To test:

  1. Confirm new test fails on main and passes here
  2. Confirm there are no type errors in test_write_nexus.py and functionality unchanged other than new test

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c15d80) 92.89% compared to head (bee42b7) 92.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1140   +/-   ##
=======================================
  Coverage   92.89%   92.90%           
=======================================
  Files          65       65           
  Lines        3338     3339    +1     
=======================================
+ Hits         3101     3102    +1     
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DominicOram DominicOram merged commit 0d10014 into main Feb 12, 2024
8 checks passed
@DominicOram DominicOram deleted the 1139_use_proper_beamline_name_in_nexus_file branch February 12, 2024 12:23
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1139_use_proper_beamline_name_in_nexus_file

Use proper beamline name in nexus
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write the beamline name properly in the nexus file
2 participants