Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fast grid scan without grid detect broken #686

Closed
DominicOram opened this issue May 26, 2023 · 2 comments · Fixed by DiamondLightSource/dodal#92, #752 or #793
Closed

Fast grid scan without grid detect broken #686

DominicOram opened this issue May 26, 2023 · 2 comments · Fixed by DiamondLightSource/dodal#92, #752 or #793
Assignees
@DominicOram
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Collaborator

We have a property on the beamline to turn grid detection in Artemis off and just use the provided values, this no longer works. We should fix it as part of the philosophy that all individual subplans should remain callable
@DominicOram DominicOram mentioned this issue May 30, 2023
Closed
@olliesilvester olliesilvester mentioned this issue May 31, 2023
Closed
@olliesilvester olliesilvester mentioned this issue Jun 14, 2023
Merged
@olliesilvester olliesilvester mentioned this issue Jun 21, 2023
Merged
@DominicOram
Copy link
Collaborator Author

I actually think this isn't fixed, we need a stage somewhere in the run_gridscan plan. The test should be confirming that run_gridscan stages properly

@DominicOram DominicOram reopened this Jun 30, 2023
@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label Jun 30, 2023
@DominicOram
Copy link
Collaborator Author

Also need to confirm the unstage works (currently it uses a finally rather than finalize_wrapper, which I think won't work)

@DominicOram DominicOram self-assigned this Jul 12, 2023
DominicOram added a commit that referenced this issue Jul 12, 2023
@DominicOram
(#686) FGS now stages eiger, with test
cc78c45
@DominicOram DominicOram mentioned this issue Jul 12, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
needed_for_release Issues that must be complete before the next release
Projects
Hyperion
Archived in project
Milestone
No milestone
1 participant
@DominicOram