Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Write the beamline name properly in the nexus file #1139

Closed
DominicOram opened this issue Feb 8, 2024 · 1 comment · Fixed by #1140
Closed

Write the beamline name properly in the nexus file #1139

DominicOram opened this issue Feb 8, 2024 · 1 comment · Fixed by #1140
Assignees
@DominicOram
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Collaborator

Using hyperion we write "DIAMOND BEAMLINE BL03I" into the /entry/instrument/name in the Nexus file. We should instead write "DIAMOND BEAMLINE I03" as GDA does.
@DominicOram DominicOram added the good first issue Good for newcomers label Feb 8, 2024
@DominicOram
Copy link
Collaborator Author

It's currently coming from the PV prefix as set from GDA. We can get it instead from dodal's get_beamline_name

@DominicOram DominicOram self-assigned this Feb 8, 2024
DominicOram added a commit that referenced this issue Feb 8, 2024
@DominicOram
(#1139) Use proper beamline name in nexus
59b3a05
@DominicOram DominicOram mentioned this issue Feb 8, 2024
Merged
DominicOram added a commit that referenced this issue Feb 8, 2024
@DominicOram
(#1139) Fix some typing errors from h5py ambiguity
bee42b7
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1139) Use proper beamline name in nexus
75f3e73
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1139) Fix some typing errors from h5py a…
ffc66bc 
…mbiguity
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
good first issue Good for newcomers
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use proper beamline name in nexus DiamondLightSource/hyperion
1 participant
@DominicOram