Remove walrus from assert

DiamondLightSource · Apr 29, 2024 · dae88af · dae88af
1 parent 00efcff
commit dae88af
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/hyperion/device_setup_plans/dcm_pitch_roll_mirror_adjuster.py b/src/hyperion/device_setup_plans/dcm_pitch_roll_mirror_adjuster.py
@@ -122,7 +122,8 @@ def adjust_dcm_pitch_roll_vfm_from_lut(
     yield from bps.wait(DCM_GROUP)
 
     # VFM Adjust - for I03 this table always returns the same value
-    assert (vfm_lut := vfm.bragg_to_lat_lookup_table_path) is not None
+    vfm_lut = vfm.bragg_to_lat_lookup_table_path
+    assert vfm_lut is not None
     vfm_x_adjuster = lookup_table_adjuster(
         linear_interpolation_lut(vfm_lut),
         vfm.x_mm,

diff --git a/src/hyperion/parameters/constants.py b/src/hyperion/parameters/constants.py
@@ -48,7 +48,7 @@ class DocDescriptorNames:
 @dataclass(frozen=True)
 class HardwareConstants:
     OAV_REFRESH_DELAY = 0.3
-    PANDA_FGS_RUN_UP_DEFAULT = 0.16
+    PANDA_FGS_RUN_UP_DEFAULT = 0.17
 
 
 @dataclass(frozen=True)

diff --git a/src/hyperion/parameters/plan_specific/rotation_scan_internal_params.py b/src/hyperion/parameters/plan_specific/rotation_scan_internal_params.py
@@ -54,6 +54,10 @@ class RotationScanParams(AbstractExperimentWithBeamParams):
     rotation_direction: RotationDirection = RotationDirection.NEGATIVE
     shutter_opening_time_s: float = 0.6
 
+    @validator("rotation_direction", pre=True)
+    def _parse_validator(cls, rotation_direction: str):
+        return RotationDirection(rotation_direction)
+
     @validator("rotation_direction", pre=True)
     def _parse_direction(cls, rotation_direction: str):
         return RotationDirection(rotation_direction)