-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata with Pydantic #58
Conversation
Changed the _create_attributes method to be consistent with the new metadata model.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 85.61% 86.65% +1.03%
==========================================
Files 11 11
Lines 424 442 +18
==========================================
+ Hits 363 383 +20
+ Misses 61 59 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuisFSegalla! This is a good start. I have some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. I think we are pretty much there now.
Thanks @LuisFSegalla ! |
Based on issue #42, I've made a simple Pydantic model to replace the dictionary metadata structure that is currently being used.