Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata with Pydantic #58

Merged
merged 8 commits into from
Feb 13, 2025
Merged

Metadata with Pydantic #58

merged 8 commits into from
Feb 13, 2025

Conversation

LuisFSegalla
Copy link
Contributor

Based on issue #42, I've made a simple Pydantic model to replace the dictionary metadata structure that is currently being used.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.65%. Comparing base (8f747b3) to head (277208c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   85.61%   86.65%   +1.03%     
==========================================
  Files          11       11              
  Lines         424      442      +18     
==========================================
+ Hits          363      383      +20     
+ Misses         61       59       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuisFSegalla! This is a good start. I have some suggestions.

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I think we are pretty much there now.

@GDYendell GDYendell merged commit 22061b0 into main Feb 13, 2025
19 checks passed
@GDYendell GDYendell deleted the metadata-pydantic branch February 13, 2025 09:40
@GDYendell
Copy link
Contributor

Thanks @LuisFSegalla !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants