Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define FrameReceiver unique config #52

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Define FrameReceiver unique config #52

merged 2 commits into from
Dec 6, 2024

Conversation

GDYendell
Copy link
Contributor

Fixes #46

@GDYendell GDYendell requested review from ajgdls and jsouter December 4, 2024 18:11
@GDYendell GDYendell self-assigned this Dec 4, 2024
This prevents top-level config PVs being created for these fields, which
should be unique between FrameReceiver proceses.
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.64%. Comparing base (f76c22f) to head (f0991ea).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs_odin/frame_processor.py 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   85.30%   85.64%   +0.34%     
==========================================
  Files           9       11       +2     
  Lines         415      425      +10     
==========================================
+ Hits          354      364      +10     
  Misses         61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell GDYendell merged commit 833015c into main Dec 6, 2024
19 checks passed
@GDYendell GDYendell deleted the fr-unique-config branch December 6, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrameReceiverAdapterController should have _unique_config set
2 participants