Zmq threads and context threads #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
reviewed
Aug 9, 2024
GDYendell
approved these changes
Aug 29, 2024
|
Thanks @JamesOHeaDLS ! |
|
Thanks @GDYendell for guiding me through this Odin/Eiger world! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gary,
As discussed this is my attempt at addressing some of the magic numbers by using command line argument values, or defaults.
With your suggestion of having a -t / --threads (passed to MultiPullBroker) and -z / --zmq-context-threads (passed to zmq context), I repurposed the old -z ("Set the number of zmq sockets to connect to the Eiger with") to be a "zmq_context_threads" argument.
I also renamed variables which handled this argument to match its new purpose.
The biggest change to the code (as opposed to just renaming), was adding a new argument to HandleRxSocket so that it can make use of the command line argument value.
Thanks,
James