Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file pointing to review team #902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

callumforrester
Copy link
Contributor

@callumforrester callumforrester commented Nov 14, 2024

Fixes #901

To be merged after changes to repository settings...

Instructions to reviewer on how to test:

  1. Open CODEOWNERS file in Github viewer and confirm that Github lints it
  2. Verify that the referenced team exists
  3. Verify that codeowner review is required in the dodal repository settings (requires admin access)

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@callumforrester callumforrester marked this pull request as ready for review November 14, 2024 16:10
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (ad6cc0d) to head (02a8772).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         132      132           
  Lines        5334     5334           
=======================================
  Hits         5105     5105           
  Misses        229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github insists that the file is valid so I can't disagree

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be ready for the "soft" side of this before merging. So I would like to see:

  • Some documentation on how codeowners are decided
  • Some documentation giving the policy that "All code must be approved by code owners" and reasoning
  • This change communicated with all of DAQ, probably by slack and a group meeting

I'm obviously happy to help on this if needed

@DiamondJoseph
Copy link
Contributor

Justifying my slightly glib comment above that I thought this was still testing in Callum's repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS
3 participants