Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ophyd async speedup #895

Merged
merged 44 commits into from
Nov 12, 2024
Merged

Test ophyd async speedup #895

merged 44 commits into from
Nov 12, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Nov 8, 2024

Following changes in bluesky/ophyd-async#641 the sped up tests uncovered some places where our tests were failing due to references to devices that weren't wrapped in Reference. This fixes the tests again.

Instructions to reviewer on how to test:

  1. Ensure tests work

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram changed the base branch from main to fixes_for_declarative_epics November 8, 2024 17:29
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (d28d4dc) to head (de596e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   95.63%   95.63%   -0.01%     
==========================================
  Files         128      128              
  Lines        5273     5271       -2     
==========================================
- Hits         5043     5041       -2     
  Misses        230      230              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram
Copy link
Contributor Author

@Relm-Arrowny - I added the references and fixed the tests but I'm not 100% sure how else the device is used so I don't know if I've broken things elsewhere. I also noticed you're using quite a few References, we tend not to need them much in MX, do you want to have a chat to compare approaches?

@Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny - I added the references and fixed the tests but I'm not 100% sure how else the device is used so I don't know if I've broken things elsewhere. I also noticed you're using quite a few References, we tend not to need them much in MX, do you want to have a chat to compare approaches?

Yes, but I am away for the next two weeks may be we can make time when I get back.

Copy link
Contributor

@Relm-Arrowny Relm-Arrowny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look fine to me.

@DominicOram DominicOram marked this pull request as ready for review November 11, 2024 12:42
Base automatically changed from fixes_for_declarative_epics to main November 11, 2024 16:23
@DominicOram DominicOram merged commit f896461 into main Nov 12, 2024
19 checks passed
@DominicOram DominicOram deleted the test_ophyd_async_speedup branch November 12, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants