-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test ophyd async speedup #895
Conversation
Remove composite results signal
…s where the children were all instances of Reference
…tandardReadableFormat
… to ophyd-async PR branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
- Coverage 95.63% 95.63% -0.01%
==========================================
Files 128 128
Lines 5273 5271 -2
==========================================
- Hits 5043 5041 -2
Misses 230 230 ☔ View full report in Codecov by Sentry. |
@Relm-Arrowny - I added the references and fixed the tests but I'm not 100% sure how else the device is used so I don't know if I've broken things elsewhere. I also noticed you're using quite a few |
Yes, but I am away for the next two weeks may be we can make time when I get back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It look fine to me.
Following changes in bluesky/ophyd-async#641 the sped up tests uncovered some places where our tests were failing due to references to devices that weren't wrapped in
Reference
. This fixes the tests again.Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}