-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
724 create an ophyd device for apple 2 undulator and add i10 as a beamline #744
724 create an ophyd device for apple 2 undulator and add i10 as a beamline #744
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 95.20% 95.58% +0.38%
==========================================
Files 120 125 +5
Lines 4984 5419 +435
==========================================
+ Hits 4745 5180 +435
Misses 239 239 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requests for clarity in some places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some typos
very odd failing test, just in python3.10. also rebasing does not work |
This was cause by this python/cpython#86579 but the strange thing for me is, the test should have never passed before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes to typing
def __init__( | ||
self, | ||
prefix: str, | ||
grating: type[Enum], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could: replace with a direct reference to I10Grating class? later on could be added or OtherGrating
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #724
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}