-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
707 add visr b01 1 as a beamline with devices #708
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 95.00% 95.02% +0.01%
==========================================
Files 116 117 +1
Lines 4744 4762 +18
==========================================
+ Hits 4507 4525 +18
Misses 237 237 ☔ View full report in Codecov by Sentry. |
64e281b
to
9ec6d16
Compare
this is still not connecting :( |
6df8028
to
6b6c6fd
Compare
src/dodal/beamlines/b01-1.py
Outdated
# set_directory_provider(PandASubdirectoryProvider()) | ||
|
||
|
||
def panda( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a panda on this beamline? I don't see it on the beamline synoptic screen, nor is there a soft-ioc for it in kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there is. there is aan argocd migration going on at the moment.
@marcelldls mentioned it shouldn't take too long
Realised I was looking at BL01B: is VISR 01B or 01C? There's no synoptic screen for the latter. |
@DiamondJoseph , ViSR is the C variant and it does not have an epics screen |
5456f80
to
5adfca4
Compare
c73d3e7
to
27a7af2
Compare
panda is supposed to be off at the moment |
c4d47b2
to
17592bc
Compare
trying to fix manta connect errors, pending comment from @marcelldls |
0b89ab2
to
024aad9
Compare
362c3b7
to
4a0ec5a
Compare
connects ok |
4a0ec5a
to
bf93291
Compare
@DominicOram is the use of the force override for the non-standard beamline name ok here? |
Really Either way, it's probably better to just do |
bf93291
to
c853eab
Compare
@DominicOram this is quite ready now |
8fff19d
to
2f74213
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, one question otherwise good.
Fixes #707
Instructions to reviewer on how to test:
dodal connect b-01-1
is successfulChecks for reviewer
dodal connect ${BEAMLINE}