Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get aperture positions from GDA aperture names #573

Merged
merged 11 commits into from
May 31, 2024

Conversation

olliesilvester
Copy link
Collaborator

Fixes DiamondLightSource/hyperion#1336

See Hyperion PR at:

Not to be merged until associated GDA changes are done

Instructions to reviewer on how to test:

  1. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, just one comment

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good, thanks!

src/dodal/devices/aperturescatterguard.py Outdated Show resolved Hide resolved
Co-authored-by: Dominic Oram <[email protected]>
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@olliesilvester olliesilvester merged commit eda8a2a into main May 31, 2024
10 checks passed
@olliesilvester olliesilvester deleted the hyperion_1336_move_aperture_before_rotation branch May 31, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to aperture from GDA before rotation
3 participants