Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build #221

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix docs build #221

merged 2 commits into from
Oct 31, 2023

Conversation

DominicOram
Copy link
Contributor

Fixes #218

Taken from DiamondLightSource/python3-pip-skeleton@6f588b9

Instructions to reviewer on how to test:

  1. Confirm docs build now passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #221 (b980f9b) into main (724330a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          71       71           
  Lines        2451     2451           
=======================================
  Hits         2194     2194           
  Misses        257      257           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DominicOram DominicOram mentioned this pull request Oct 29, 2023
2 tasks
Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for sorting this out

@dperl-dls dperl-dls merged commit ef5d460 into main Oct 31, 2023
16 checks passed
@dperl-dls dperl-dls deleted the 218_fix_docs_by_merging_skeleton branch October 31, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc build broken
2 participants